Should I redesign my forum logo? Options

[Tommy Hara]

Hello,

I designed this logo since a year ago and now my forum's having more visits so I'm going to redesign some parts on it
First, I think of redesigning my logo here with corel draw to look better

You can see it http://www.webmastersun.com in complete website design.

According to you, Should I redesign my logo?

[pandy]

I don't know, what do you think it wrong with it?

I do think though that you should get rid of the snip of javascript that displays at the top of the pages in some browsers (due to an unescaped slash in a closing tag in a document write). I would also get rid of the other HTML errors. Looks pretty bad on a webmaster site. Among other things you need to decide if you want to use HTML or XHTML and stick to the flavour you choose.

http://htmlhelp.com/cgi-bin/validate.cgi?u...s&input=yes

[jimlongo]

It looks okay to me.
I didn't know anyone still used Corel Draw.

[Tommy Hara]

I don't know, what do you think it wrong with it?

I do think though that you should get rid of the snip of javascript that displays at the top of the pages in some browsers (due to an unescaped slash in a closing tag in a document write). I would also get rid of the other HTML errors. Looks pretty bad on a webmaster site. Among other things you need to decide if you want to use HTML or XHTML and stick to the flavour you choose.

http://htmlhelp.com/cgi-bin/validate.cgi?u...s&input=yes

Thank for good feedbacks!

can you send me screenshot about thing you said "I do think though that you should get rid of the snip of javascript that displays at the top of the pages in some browsers" ?

Thank you

This post has been edited by Tommy Hara: May 14 2014, 11:11 PM

[pandy]

It's this snip.

CODE

'); var sidebar_align = 'right'; var content_container_margin = parseInt('320px'); var sidebar_width = parseInt('300px'); //-->

It happens because you haven't escaped the slash in the closing SCRIPT tag in the document.write() here.

CODE

    <script type="text/javascript">
    <!--
        document.write('<script type="text/javascript" src="' + yuipath + '/animation/animation-min.js?v=420"></script>');
                                                                                                              ^^^
        var sidebar_align = 'right';
...

It effectively closes the script block. When you have HTML written by JavaScript you must escape the closing slashes with a backslash, like so.

CODE

<\/script>

This time it happened to be </script> and caused more harm than if it had for instance been </p>.

BTW if you are going to write XHTML you can't have those hide from old browsers comments in the script block either.
http://www.w3.org/TR/xhtml1/#h-4.8

[Christian J]

BTW if you are going to write XHTML you can't have those hide from old browsers comments in the script block either.
http://www.w3.org/TR/xhtml1/#h-4.8

You can't use document.write either: http://www.w3.org/MarkUp/2004/xhtml-faq#docwrite

Usually the simplest solution is to not use XHTML, since it offers no benefits (it's not even fashionable anymore ). Use e.g. HTML5 instead.

[pandy]

Right, had forgotten about that. I blame the fact that I've never actually used XHTML (more than forced to by software that output it, like this forum).