Quotes error, Mission imposible or not ? Options

[shower]

I have a big problem , i need to add the quad quotation marks in themselfs.
My englis is poor, so i will write code down

$html .= '<a href="#" onclick=\'createNewTab("ajax","#{title}","<img src= !THERE! http://pgs.avx.pl/PGBA/loading.gif !THERE! > Proszę czekać, ładowanie...","#{link}");return false\'>#{title}</a><br>';

in place of !THERE! i need to add the fourth quotation mark
So it looks like that:
'.....\'....".....??-and how i can add one more type of quotation mark here?...??...."...\'....'

This post has been edited by shower: Sep 17 2006, 01:45 PM

[pandy]

Hi,

I don't know what programming alnguage you use, but obviously you can use escapes because you did so here: onclick=\'createNewTab . So can't you simply escape all quotes around HTML attributes? Is there a reason you can't do that?

[Christian J]

The $html variable looks like PHP, but I don't think that's the problem. The problem seems to be that the onclick event sends an argument containing quotes:

HTML

onclick=\'createNewTab("ajax","#{title}","<img src="http://pgs.avx.pl/PGBA/loading.gif"> Proszę czekać, ładowanie...","#{link}");return false"

Escaping double quotes doesn't seem to help, can't you do that? But if you turn them into single quotes you can escape them:

HTML

onclick="createNewTab('ajax', '#{title}', '<img src=\'http:\/\/pgs.avx.pl\/PGBA\/loading.gif\'> Prosze czekac, ladowanie...', '#{link}'); return false"

Note that this requires rewriting and possible escaping of the PHP variable as well.

[Christian J]

Also you shouldn't use

CODE

<a href="#" onclick="..."

try instead to use a HREF value that makes sense if javascript is disabled.

[pandy]

You ,mrean the output doesn't work, JS error? I don't understand, do you really mean PHP can't escape double quotes?

Wouldn't this work?
onclick=\'createNewTab("ajax","#{title}","<img src= \\"http://pgs.avx.pl/PGBA/loading.gif\\">...

[Christian J]

You ,mrean the output doesn't work, JS error?

No, isn't it an HTML error if part of the onclick attribute's value is rendered in the link text?

I don't understand, do you really mean PHP can't escape double quotes?

It can, I just meant PHP is not involved in the basic problem, so I removed it from my examples (maybe that's not very helpful but I feel lazy. ).

Wouldn't this work?
onclick=\'createNewTab("ajax","#{title}","<img src= \\"http://pgs.avx.pl/PGBA/loading.gif\\">...

Aha, you must escape double quotes with double backslashes? That seems to work:

CODE

<a href="#" onclick='createNewTab("ajax","#{title}","<img src=\\"http://pgs.avx.pl/PGBA/loading.gif\\"> Prosze czekac, ladowanie...","#{link}");return false'>#{title}</a>

[pandy]

It does? It didn't work for me.

My, probably dumb, thinking was that to print a literal "\" you need to escape it. So it works for you? Maybe I made a typo when I tried. I get nervous around PHP.

[Christian J]

But I'm not inclusing the PHP syntax, I told you!

Here's a PHP example since you insist:

CODE

$html .= '<a href="#" onclick=\'createNewTab("ajax","#{title}","<img src=\\"http://pgs.avx.pl/PGBA/loading.gif\\"> Prosze czekac, ladowanie...","#{link}");return false\'>#{title}</a><br>';

[Christian J]

My, probably dumb, thinking was that to print a literal "\" you need to escape it.

Now I think I understood what you meant (I'm a bit dense for once). That makes sense, but in my post above I didn't mean PHP at all, just plain HTML. It seems you need two backslashes to escape a double quote there too.

[Christian J]

Wonder if the OP is enough confused by now? Maybe we (I) should clean up this thread.

[pandy]

Double escapes in the JS?

How can you clean it up when we don't know what's true or not? You'll just delete the wrong, or rather right, things..

[Christian J]

Double escapes in the JS?

Darn. It seemed to work before.

In other words, you can't escape double quotes in HTML/JS like you can with single quotes?

How can you clean it up when we don't know what's true or not? You'll just delete the wrong, or rather right, things..

Yes ma'm.